Help!

[PATCH 1/1] perf symbols: Initialize dso->loaded

 
  

Post new topic   General Reply to Topic (not reply to a specific post)    Forums Home -> Kernel RSS
Next:  Accepted flash-kernel 2.27 (source armel)  
Author Message
Arnaldo Carvalho de Melo
External


Since: Oct 29, 2009
Posts: 8



PostPosted: Tue Nov 03, 2009 2:10 pm    Post subject: [PATCH 1/1] perf symbols: Initialize dso->loaded
Archived from groups: linux>kernel (more info?)

From: Arnaldo Carvalho de Melo <acme.RemoveThis@redhat.com>

Brown paper bag bug introduced in:

66bd8424cc05e800db384053bf7ab967e4658468

Without this we were not loading any symtabs that happened to be on a
DSO for which the allocated memory for ->loaded was !0.

Cc: Frederic Weisbecker <fweisbec.RemoveThis@gmail.com>
Cc: Peter Zijlstra <peterz.RemoveThis@infradead.org>
Cc: Paul Mackerras <paulus.RemoveThis@samba.org>
Cc: Mike Galbraith <efault.RemoveThis@gmx.de>
Signed-off-by: Arnaldo Carvalho de Melo <acme.RemoveThis@redhat.com>
---
tools/perf/util/symbol.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index ec99d79..ac94d7b 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -121,6 +121,7 @@ struct dso *dso__new(const char *name)
self->find_symbol = dso__find_symbol;
self->slen_calculated = 0;
self->origin = DSO__ORIG_NOT_FOUND;
+ self->loaded = false;
}

return self;
--
1.6.2.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo.RemoveThis@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to top
tip-bot for Arnaldo Carva
External


Since: May 15, 2009
Posts: 12



PostPosted: Tue Nov 03, 2009 2:10 pm    Post subject: [tip:perf/core] perf symbols: Initialize dso->loaded [Login to view extended thread Info.]
Archived from groups: per prev. post (more info?)

Commit-ID: 6d7aa9d721c8c640066142fd9534afcdf68d7f9d
Gitweb: http://git.kernel.org/tip/6d7aa9d721c8c640066142fd9534afcdf68d7f9d
Author: Arnaldo Carvalho de Melo <acme DeleteThis @redhat.com>
AuthorDate: Tue, 3 Nov 2009 15:52:18 -0200
Committer: Ingo Molnar <mingo DeleteThis @elte.hu>
CommitDate: Tue, 3 Nov 2009 18:56:06 +0100

perf symbols: Initialize dso->loaded

Brown paper bag bug introduced in:

66bd8424cc05e800db384053bf7ab967e4658468 ("perf tools: Delay
loading symtabs till we hit a map with it")

Without this we were not loading any symtabs that happened to be
on a DSO for which the allocated memory for ->loaded was !0.

Signed-off-by: Arnaldo Carvalho de Melo <acme DeleteThis @redhat.com>
Cc: Frederic Weisbecker <fweisbec DeleteThis @gmail.com>
Cc: Peter Zijlstra <peterz DeleteThis @infradead.org>
Cc: Paul Mackerras <paulus DeleteThis @samba.org>
Cc: Mike Galbraith <efault DeleteThis @gmx.de>
LKML-Reference: <1257270738-5669-1-git-send-email-acme DeleteThis @infradead.org>
Signed-off-by: Ingo Molnar <mingo DeleteThis @elte.hu>
---
tools/perf/util/symbol.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index cf2c7f7..93c49f4 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -121,6 +121,7 @@ struct dso *dso__new(const char *name)
self->find_symbol = dso__find_symbol;
self->slen_calculated = 0;
self->origin = DSO__ORIG_NOT_FOUND;
+ self->loaded = false;
}

return self;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo DeleteThis @vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to top
Display posts from previous:   
Post new topic   General Reply to Topic (not reply to a specific post)    Forums Home -> Kernel All times are: Eastern Time (US & Canada) (change)
Page 1 of 1

 
You can post new topics in this forum
You can reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum