[PATCH 1/1] PM: Making bdi threads non-freezable

Dasgupta, Romit · External Since: Nov 02, 2009 Posts: 7

Fixes the case when bdi threads are in the refrigerator but file system sync
can happen after this. This is possible in MMC when CONFIG_MMC_UNSAFE_RESUME is
not set.

Signed-off-by: Romit Dasgupta <romit.DeleteThis@ti.com>
---

diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index 9d5360c..661229d 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -956,7 +956,6 @@ int bdi_writeback_task(struct bdi_writeback *wb)

wait_jiffies = msecs_to_jiffies(dirty_writeback_interval * 10);
schedule_timeout_interruptible(wait_jiffies);
- try_to_freeze();
}

return 0;
diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index 5a37e20..9383271 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -273,7 +273,6 @@ static void bdi_task_init(struct backing_dev_info *bdi,
spin_unlock(&bdi->wb_lock);

tsk->flags |= PF_FLUSHER | PF_SWAPWRITE;
- set_freezable();

/*
* Our parent may run at a different priority, just set us to normal
@@ -419,7 +418,6 @@ static int bdi_forker_task(void *ptr)
spin_unlock_bh(&bdi_lock);
wait = msecs_to_jiffies(dirty_writeback_interval * 10);
schedule_timeout(wait);
- try_to_freeze();
continue;
}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo.DeleteThis@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Rafael J. Wysocki · External Since: May 20, 2006 Posts: 1721

On Monday 02 November 2009, Dasgupta, Romit wrote:
> Fixes the case when bdi threads are in the refrigerator but file system sync
> can happen after this. This is possible in MMC when CONFIG_MMC_UNSAFE_RESUME is
> not set.

What's going to happen if we attemt to suspend the underlying block device(s)
when the bdi thread are doing their job? Is there any synchronisation
mechanism for that?

Rafael

> Signed-off-by: Romit Dasgupta <romit RemoveThis @ti.com>
> ---
>
> diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> index 9d5360c..661229d 100644
> --- a/fs/fs-writeback.c
> +++ b/fs/fs-writeback.c
> @@ -956,7 +956,6 @@ int bdi_writeback_task(struct bdi_writeback *wb)
>
> wait_jiffies = msecs_to_jiffies(dirty_writeback_interval * 10);
> schedule_timeout_interruptible(wait_jiffies);
> - try_to_freeze();
> }
>
> return 0;
> diff --git a/mm/backing-dev.c b/mm/backing-dev.c
> index 5a37e20..9383271 100644
> --- a/mm/backing-dev.c
> +++ b/mm/backing-dev.c
> @@ -273,7 +273,6 @@ static void bdi_task_init(struct backing_dev_info *bdi,
> spin_unlock(&bdi->wb_lock);
>
> tsk->flags |= PF_FLUSHER | PF_SWAPWRITE;
> - set_freezable();
>
> /*
> * Our parent may run at a different priority, just set us to normal
> @@ -419,7 +418,6 @@ static int bdi_forker_task(void *ptr)
> spin_unlock_bh(&bdi_lock);
> wait = msecs_to_jiffies(dirty_writeback_interval * 10);
> schedule_timeout(wait);
> - try_to_freeze();
> continue;
> }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo RemoveThis @vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Dasgupta, Romit · External Since: Nov 02, 2009 Posts: 7

> Subject: Re: [PATCH 1/1] PM: Making bdi threads non-freezable
>
> On Monday 02 November 2009, Dasgupta, Romit wrote:
> > Fixes the case when bdi threads are in the refrigerator but file system sync
> > can happen after this. This is possible in MMC when
> CONFIG_MMC_UNSAFE_RESUME is
> > not set.
>
> What's going to happen if we attemt to suspend the underlying block device(s)
> when the bdi thread are doing their job? Is there any synchronisation
> mechanism for that?
>
There is no explicit synchronization AFAICT. However, it looks like the call to 'del_gendisk' would invoke 'sync_filesystem' down the line. 'sync_filesystem' would end with synchronous writes of inodes followed by a call to '__sync_blockddev'.
After this call I believe there should not be any activity pending for the blockdevice. So this should not lead to any race. My tests on the development board did not show any issues. But some FS experts may comment.

Regards,
-Romit

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo.DeleteThis@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Rafael J. Wysocki · External Since: May 20, 2006 Posts: 1721

On Tuesday 03 November 2009, Dasgupta, Romit wrote:
>
> > Subject: Re: [PATCH 1/1] PM: Making bdi threads non-freezable
> >
> > On Monday 02 November 2009, Dasgupta, Romit wrote:
> > > Fixes the case when bdi threads are in the refrigerator but file system sync
> > > can happen after this. This is possible in MMC when
> > CONFIG_MMC_UNSAFE_RESUME is
> > > not set.
> >
> > What's going to happen if we attemt to suspend the underlying block device(s)
> > when the bdi thread are doing their job? Is there any synchronisation
> > mechanism for that?
> >
> There is no explicit synchronization AFAICT. However, it looks like the call
> to 'del_gendisk' would invoke 'sync_filesystem' down the line.
> 'sync_filesystem' would end with synchronous writes of inodes followed by a
> call to '__sync_blockddev'.

However, that runs concurrently with respect to the suspend thread, AFAICS, so
I wonder if there's anything to make the suspend thread wait for these
operations to complete. If there's nothing like that, we can't really allow
the bdi threads to run in parallel with the suspend thread.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo.RemoveThis@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/