Bug#242216: xserver-xfree86.config hardcodes different def..

Nikita V. Youshchenko · External Since: Nov 13, 2004 Posts: 58

Package: xserver-xfree86
Version: 4.3.0-7
Severity: normal
Tags: patch

xserver-xfree86.config contains the following code:

....

if [ "$RET" = "true" ]; then
db_subst xserver-xfree86/config/monitor/selection-method choices "Medium, Advanced"
db_subst xserver-xfree86/config/monitor/selection-method default "Medium"
else # not an LCD
db_subst xserver-xfree86/config/monitor/selection-method choices "Simple, Medium, Advanced"
db_subst xserver-xfree86/config/monitor/selection-method default "Simple"
fi

auto_answer db_input "$(priority_ceil $PRIORITY)" xserver-xfree86/config/monitor/selection-method "Advanced"

....

Thus default answer for xserver-xfree86/config/monitor/selection-method
is "Simple" or "Medium" (which is good for non-technical users), but if
debconf actually asks the question, the default shown answer is
hardcoded to "Advanced". Since users tend to accept all defaults they
see (even after a help screen was shown describing what the selections
mean), too often they select this default and are faced with questions
about frequences they can't understand. And even can't go back at that
point.

So it seems better to show a "silly-safe" choise by default. I.e. the
same as is set in the case when question is not asked.

--- xserver-xfree86.config.orig 2004-04-05 16:02:07.000000000 +0400
+++ xserver-xfree86.config 2004-04-05 16:06:21.000000000 +0400
@@ -1568,13 +1568,14 @@
MONITOR_IS_LCD="$RET"
if [ "$RET" = "true" ]; then
db_subst xserver-xfree86/config/monitor/selection-method choices "Medium, Advanced"
- db_subst xserver-xfree86/config/monitor/selection-method default "Medium"
+ DEFAULT="Medium"
else # not an LCD
db_subst xserver-xfree86/config/monitor/selection-method choices "Simple, Medium, Advanced"
- db_subst xserver-xfree86/config/monitor/selection-method default "Simple"
+ DEFAULT="Simple"
fi

-auto_answer db_input "$(priority_ceil $PRIORITY)" xserver-xfree86/config/monitor/selection-method "Advanced"
+db_subst xserver-xfree86/config/monitor/selection-method default $DEFAULT
+auto_answer db_input "$(priority_ceil $PRIORITY)" xserver-xfree86/config/monitor/selection-method $DEFAULT

db_get xserver-xfree86/config/monitor/selection-method
case "$RET" in

--
To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST RemoveThis @lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster RemoveThis @lists.debian.org

Nikita V. Youshchenko · External Since: Nov 13, 2004 Posts: 58

> Your patch is incomplete; there is no auto_answer counterpart for the
> "Simple" and "Medium" monitor selection methods.

Could you please explain what you mean?
I've looked at the code of auto_answer, and I fail to find what else is
needed to change default displayed answer.

auto_answer routine seems do put it's fourth argiment to debconf database
using db_set. So in current code it puts "Advanced" there, in my patch it
will put $DEFAULT there instead. I fail to understand why this is not
enough.

--
To UNSUBSCRIBE, email to debian-x-REQUEST.RemoveThis@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster.RemoveThis@lists.debian.org

Julien Cristau · External Since: Jan 07, 2007 Posts: 396

tags 242216 - patch
reassign 242216 xserver-xorg
kthxbye

On Thu, Apr 8, 2004 at 11:29:46 +0400, Nikita V. Youshchenko wrote:

> > > Could you please explain what you mean?
> >
> > Sure.
> > ...
> > I am referring to the large case statement at line 990 of
> > xserver-xfree86.config.in[1].
> >
> > The Simple) and Medium) cases have no auto-answer logic. Your patch
> > should not be applied until they do.
>
> I'm not sure I understand why auto_answer logic is needed there, but anyway
> the attached patch is probably what you wish.
>
Hi,

is this bug still a problem for you with the current xserver-xorg
package configuration?

Cheers,
Julien

--
To UNSUBSCRIBE, email to debian-bugs-dist-REQUEST.DeleteThis@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster.DeleteThis@lists.debian.org