Attempt at packaging StringTemplate

Florian Weimer · External Since: Nov 10, 2004 Posts: 607

Would anyone familiar with Java packaging please review my attempt at
packaging StringTemplate?

$ git clone http://git.enyo.de/fw/debian/stringtemplate.git

I'm not quite sure about the build dependencies, and how to force ant
to use a particularly Java compiler if multiple ones are installed.

--
To UNSUBSCRIBE, email to debian-java-REQUEST RemoveThis @lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster RemoveThis @lists.debian.org

Michael Koch · External Since: Feb 18, 2005 Posts: 543

On Sun, Apr 22, 2007 at 04:26:10PM +0200, Florian Weimer wrote:
> Would anyone familiar with Java packaging please review my attempt at
> packaging StringTemplate?
>
> $ git clone http://git.enyo.de/fw/debian/stringtemplate.git
>
> I'm not quite sure about the build dependencies, and how to force ant
> to use a particularly Java compiler if multiple ones are installed.

- You dont need to Build-Depend on ant. ant-optional already Depends on
it.

- You should Build-Depend on antlr when build.properties references it
and its used.

- The full descrition of the package should read "Homepage: ..." and not
"URL: ...". "Homepage" is a reserved word in full descriptions.

- You should set JAVA_HOME env var to /usr/lib/jvm/java-gcj. With that
set ant uses always java-gcj-compat-dev for building and you have a
reproducible build setup.

- You should call the binary package either stringtemplate or
libstringtemplate-java. Not stringtemplate-java. When its a tool it
doesnt matter if its written in java or any other languages. That is
only important for libraries.

- You dont need to add "usr/share/doc/stringtemplate-java" to
debian/stringtemplate-java.dirs. That is automatically created by
debhelper.

- Your binary package contains the following:

-rwxr-xr-x root/root 127758 2007-04-22 18:02 ./usr/share/java/stringtemplate-3.0.jar

A jar file should not be executable.

- You compile the Java classes without debug symbols. These debug stuff
dont hurt. Our policy is to include them to make it easy when you get
Java stacktraces.

- Your debian/rules contains some commented out cruft which is just not
needed.

- I would use CDBS for debian/rules. This makes some things implicitely
and is more easy to maintain. And for Debian Java packages its the
standard. Java people people will be able to help you more easy.
>
>
> --
> To UNSUBSCRIBE, email to debian-java-REQUEST.RemoveThis@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact listmaster.RemoveThis@lists.debian.org
>

--
.''`. | Michael Koch <konqueror.RemoveThis@gmx.de>
: :' : | Free Java Developer <http://www.classpath.org>
`. `' |
`- | 1024D/BAC5 4B28 D436 95E6 F2E0 BD11 5923 A008 2763 483B

--
To UNSUBSCRIBE, email to debian-java-REQUEST.RemoveThis@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster.RemoveThis@lists.debian.org

Florian Weimer · External Since: Nov 10, 2004 Posts: 607

* Michael Koch:

> - You dont need to Build-Depend on ant. ant-optional already Depends on
> it.
>
> - You should Build-Depend on antlr when build.properties references it
> and its used.

Okay, although it's pulled in by gjdoc already.

> - You should call the binary package either stringtemplate or
> libstringtemplate-java. Not stringtemplate-java. When its a tool it
> doesnt matter if its written in java or any other languages. That is
> only important for libraries.

libstringtemplate-java it is. There are implementations in other
languages.

> - I would use CDBS for debian/rules. This makes some things implicitely
> and is more easy to maintain. And for Debian Java packages its the
> standard. Java people people will be able to help you more easy.

Hmm. I don't particularly like CDBS, but I've switched to it. That
seems to fix the other issues you mentioned. (You need a fresh clone
because I've amended the commit.)

Thanks much for your helpful comments.

--
To UNSUBSCRIBE, email to debian-java-REQUEST.TakeThisOut@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster.TakeThisOut@lists.debian.org

Michael Koch · External Since: Feb 18, 2005 Posts: 543

On Sun, Apr 22, 2007 at 06:57:18PM +0200, Florian Weimer wrote:
> * Michael Koch:
>
> > - You dont need to Build-Depend on ant. ant-optional already Depends on
> > it.
> >
> > - You should Build-Depend on antlr when build.properties references it
> > and its used.
>
> Okay, although it's pulled in by gjdoc already.

Don't depend on this fact. We are thinking of switching away from gjdoc
to sinjdoc perhaps. Or javadoc from SUN. (Yes, I have seen that you
added it).

> Hmm. I don't particularly like CDBS, but I've switched to it. That
> seems to fix the other issues you mentioned. (You need a fresh clone
> because I've amended the commit.)

I guess this is done by CDBS calling dh_fixperms.

Cheers,
Michael
--
.''`. | Michael Koch <konqueror RemoveThis @gmx.de>
: :' : | Free Java Developer <http://www.classpath.org>
`. `' |
`- | 1024D/BAC5 4B28 D436 95E6 F2E0 BD11 5923 A008 2763 483B

--
To UNSUBSCRIBE, email to debian-java-REQUEST RemoveThis @lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster RemoveThis @lists.debian.org

Florian Weimer · External Since: Nov 10, 2004 Posts: 607

* Michael Koch:

> Don't depend on this fact. We are thinking of switching away from gjdoc
> to sinjdoc perhaps. Or javadoc from SUN.

Yes, makes sense.

> (Yes, I have seen that you added it).

Thanks again. Shall I upload the package? Do you think it would be
generally useful?

>> Hmm. I don't particularly like CDBS, but I've switched to it. That
>> seems to fix the other issues you mentioned. (You need a fresh clone
>> because I've amended the commit.)
>
> I guess this is done by CDBS calling dh_fixperms.

No, I just fixed the install call. Cool

--
To UNSUBSCRIBE, email to debian-java-REQUEST.TakeThisOut@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster.TakeThisOut@lists.debian.org

Michael Koch · External Since: Feb 18, 2005 Posts: 543

On Sun, Apr 22, 2007 at 10:17:41PM +0200, Florian Weimer wrote:
> Thanks again. Shall I upload the package? Do you think it would be
> generally useful?

Yes, I think so. If you do it, I would prefer when you use the Debian
Java Maintainers in the Maintainer field and yourself in the Uploaders
field and put the packaging stuff (debian dir) in alioth pkg-java SVN.

This is my personal preference to keep every Java package this way. You
dont need to do it.

Cheers,
Michael
--
.''`. | Michael Koch <konqueror RemoveThis @gmx.de>
: :' : | Free Java Developer <http://www.classpath.org>
`. `' |
`- | 1024D/BAC5 4B28 D436 95E6 F2E0 BD11 5923 A008 2763 483B

--
To UNSUBSCRIBE, email to debian-java-REQUEST RemoveThis @lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster RemoveThis @lists.debian.org